Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: generated message types reference proto-plus #680

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

software-dov
Copy link
Contributor

Multiple issues have been filed indicating that json marshalling has
been broken and the fix is not obvious.
This will hopefully be ameliorated by indicating the inheritance from
proto.Message, with a link to the appropriate documentation.

Multiple issues have been filed indicating that json marshalling has
been broken and the fix is not obvious.
This will hopefully be ameliorated by indicating the inheritance from
proto.Message, with a link to the appropriate documentation.
@software-dov software-dov requested a review from a team as a code owner October 21, 2020 17:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2020
@software-dov software-dov added the automerge Merge the pull request once unit tests and other checks pass. label Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #680   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1561      1561           
  Branches       315       315           
=========================================
  Hits          1561      1561           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0c9b2...e7fb302. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 23327b2 into googleapis:master Oct 21, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 21, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 21, 2020
@software-dov software-dov linked an issue Oct 21, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make inheritance from proto.Message clear in docs
2 participants