Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also add the async client to __all__ #869

Merged
merged 2 commits into from
May 7, 2021
Merged

fix: also add the async client to __all__ #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec78f2
fix: also add the async client to __all__
busunkim96 May 7, 2021
0523dfc
chore: remove stray } in feature fragments
busunkim96 May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gapic/templates/%namespace/%name_%version/%sub/__init__.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ __all__ = (
{% for service in api.services.values()
if service.meta.address.subpackage == api.subpackage_view -%}
'{{ service.client_name }}',
{% if 'grpc' in opts.transport %}
'{{ service.async_client_name }}',
{% endif %}
{% endfor -%}
{% for proto in api.protos.values()
if proto.meta.address.subpackage == api.subpackage_view -%}
Expand Down
2 changes: 1 addition & 1 deletion gapic/templates/examples/feature_fragments.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ with open({{ attr.input_parameter }}, "rb") as f:
{% macro render_client_setup(module_name, client_name) %}
# Create a client
client = {{ module_name }}.{{ client_name }}()
{% endmacro %}}
{% endmacro %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated fix to the template file.


{% macro render_request_setup(full_request, module_name, request_type) %}
# Initialize request argument(s)
Expand Down