Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Create a new ClientInfo if none is provided. #2289

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Create a new ClientInfo if none is provided. #2289

merged 2 commits into from
Oct 31, 2018

Conversation

lukesneeringer
Copy link
Contributor

Fixes #2161.

@lukesneeringer lukesneeringer self-assigned this Sep 4, 2018
@codecov-io
Copy link

codecov-io commented Sep 4, 2018 •
edited
Loading

Codecov Report

Merging #2289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2289   +/-   ##
=========================================
  Coverage     86.73%   86.73%           
  Complexity     5241     5241           
=========================================
  Files           458      458           
  Lines         20881    20881           
  Branches       2252     2252           
=========================================
  Hits          18111    18111           
  Misses         1968     1968           
  Partials        802      802

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d600a...03f2c35. Read the comment docs.

@michaelbausor
Copy link
Contributor

Ping on this - can it be merged?

tseaver
tseaver approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like a reasonable fix for #2161 and googleapis/google-cloud-python#5710.

@tseaver tseaver mentioned this pull request Sep 18, 2018
Closed
@tseaver
Copy link
Contributor

tseaver commented Oct 5, 2018

@lukesneeringer Ping?

1 similar comment
@tseaver
Copy link
Contributor

tseaver commented Oct 11, 2018

@lukesneeringer Ping?

@theacodes
Copy link

@googleapis/toolchain can someone look at this? It's still a problem for us.

@lukesneeringer lukesneeringer merged commit 0be30d8 into master Oct 31, 2018
@lukesneeringer lukesneeringer deleted the issue-2161 branch October 31, 2018 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbolinger jbolinger jbolinger approved these changes

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees

@lukesneeringer lukesneeringer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lukesneeringer @codecov-io @michaelbausor @tseaver @theacodes @jbolinger @landrito