-
Notifications
You must be signed in to change notification settings - Fork 130
py,go,java: remove send/recv msg size limit #2900
Conversation
Java doesn't seem to support |
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
============================================
- Coverage 87.34% 87.34% -0.01%
+ Complexity 5854 5853 -1
============================================
Files 477 477
Lines 23223 23223
Branches 2507 2507
============================================
- Hits 20285 20284 -1
Misses 2100 2100
- Partials 838 839 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
============================================
+ Coverage 87.33% 87.33% +<.01%
Complexity 5858 5858
============================================
Files 477 477
Lines 23237 23238 +1
Branches 2510 2510
============================================
+ Hits 20295 20296 +1
Misses 2100 2100
Partials 842 842
Continue to review full report at Codecov.
|
Oops! I assumed 🤦♂️ Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The latter changes to the Go snippets were essentially copied from googleapis/gapic-generator-go#165 |
I opened grpc/grpc#19810 to see if the restriction could be lifted in gRPC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR broke autosynth in Python.
options={ | ||
'grpc.max_send_message_length': -1, | ||
'grpc.max_receive_message_length': -1, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs to have .items()
tacked on (options
is expected to be a sequence of two-tuples, not a dict).
Fixes #2895 for python, Go and Java
Node.js (grpc-js) does not check size limits, therefore it is already unbounded.