Stop using VersionPrefix and then a suffix

We don't do this in google-cloud-dotnet, and it's basically a leftover from MyGet days

Google.Api.CommonProtos/Google.Api.CommonProtos.csproj

@@ -3,7 +3,7 @@
   <Import Project="..\CommonProperties.Production.xml" />
 
   <PropertyGroup>
-    <VersionPrefix>1.4.0</VersionPrefix>
+    <Version>1.4.0</Version>
     <TargetFrameworks>netstandard1.3;net45</TargetFrameworks>
   </PropertyGroup>
 

ReleaseVersion.xml

@@ -5,6 +5,6 @@
     - divergent versions, but for the moment this keeps things simpler.
     -->
   <PropertyGroup>
-    <VersionPrefix>2.5.0</VersionPrefix>
+    <Version>2.5.0</Version>
   </PropertyGroup>
 </Project>

build.sh

@@ -2,13 +2,6 @@
 
 set -e
 
-# Myget has sometimes used caps and sometimes not for
-# its environment variables...
-if [ -n "$PrereleaseTag" -a -z "$PRERELEASETAG" ]
-then
-  PRERELEASETAG="$PrereleaseTag"
-fi
-
 # Clean up previous builds
 rm -rf {src,test,testing}/*/bin {src,test,testing}/*/obj
 
@@ -18,18 +11,6 @@ DOTNET_BUILD_ARGS="-c $CONFIG"
 # Arguments to use for test-related commands (test)
 DOTNET_TEST_ARGS="--no-build $DOTNET_BUILD_ARGS"
 
-# Three options:
-# - No environment variables: make sure it's not for release
-# - PRERELEASETAG set: use that
-# - NOVERSIONSUFFIX set: use no suffix; build as per project.json
-if [ -n "$PRERELEASETAG" ]
-then
-  DOTNET_BUILD_ARGS="$DOTNET_BUILD_ARGS --version-suffix $PRERELEASETAG"
-elif [ -z "$NOVERSIONSUFFIX" ]
-then
-  DOTNET_BUILD_ARGS="$DOTNET_BUILD_ARGS --version-suffix dont-release"  
-fi
-
 echo CLI args: $DOTNET_BUILD_ARGS
 
 echo Restoring

buildrelease.sh

@@ -32,7 +32,6 @@ git clone https://github.com/googleapis/gax-dotnet.git releasebuild -c core.auto
 cd releasebuild
 git checkout $tag
 export CI=true # Forces SourceLink in the main build.
-export NOVERSIONSUFFIX=true
 ./build.sh
 dotnet pack Gax.sln --no-build -o $PWD/nuget -c Release