Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use ordinal string operations #726

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Sep 26, 2023

Checked:

  • IndexOf
  • StartsWith
  • EndsWith
  • OrderBy
  • Sort
  • Compare

(Annoyingly, for StartsWith and EndsWith there are various single-character cases where a character literal would do the right thing - but those overloads aren't supported on .NET Framework.)

Checked:

- IndexOf
- StartsWith
- EndsWith
- OrderBy
- Sort
- Compare

(Annoyingly, for StartsWith and EndsWith there are various
single-character cases where a character literal would do the right
thing - but those overloads aren't supported on .NET Framework.)
@jskeet jskeet requested a review from a team as a code owner September 26, 2023 09:57
@jskeet
Copy link
Collaborator Author

jskeet commented Sep 26, 2023

Fixes #725.

@jskeet jskeet closed this Sep 26, 2023
@jskeet jskeet reopened this Sep 26, 2023
@jskeet jskeet merged commit 9456e22 into googleapis:main Sep 26, 2023
5 checks passed
@jskeet jskeet deleted the string-comparisons branch February 9, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants