Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Google.Api.CommonProtos version 2.12.0 #730

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Oct 11, 2023

Changes since 2.11.0:

  • The package contains the original protos, in contents/protos. Build targets in the package set the GoogleApiCommonProtos_ProtosPath msbuild property, and if IncludeGoogleApiCommonProtos is set to the value true in the project, the Protobuf_StandardImportsPath property is updated to include it before the Protobuf_BeforeCompile target is executed. (This should make the package easier to work with from Grpc.Tools.)

Changes since 2.11.0:

- The package contains the original protos, in contents/protos.
  Build targets in the package set the `GoogleApiCommonProtos_ProtosPath`
  msbuild property, and if `IncludeGoogleApiCommonProtos` is set to
  the value `true` in the project, the `Protobuf_StandardImportsPath`
  property is updated to include it before the `Protobuf_BeforeCompile`
  target is executed. (This should make the package easier to work with
  from Grpc.Tools.)
@jskeet jskeet merged commit 3a37991 into googleapis:main Oct 11, 2023
3 of 4 checks passed
@jskeet jskeet deleted the release-common-protos-2 branch October 11, 2023 19:37
@yoshi-automation
Copy link

  • Created release for Google.Api.CommonProtos-2.12.0

@release-trigger
Copy link

Triggered job: cloud-sharp/gax-dotnet/gcp_windows/autorelease (2023-10-11T19:47:36.607Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

@release-tool-publish-reporter

The release build has started; the log can be viewed here.

@release-tool-publish-reporter

Release build succeeded.

@release-tool-publish-reporter

The release build has started; the log can be viewed here.

@release-tool-publish-reporter

The release build failed! Please investigate!

@jskeet
Copy link
Collaborator Author

jskeet commented Oct 11, 2023

Will look into this tomorrow.

@amanda-tarafa
Copy link
Collaborator

This is the same as always with releases from Gax. The release triggered twice, one succeeded that other failed.

Here's the updated package: https://www.nuget.org/packages/Google.Api.CommonProtos

@jskeet
Copy link
Collaborator Author

jskeet commented Oct 11, 2023

Ah, phew :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants