Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update and regenerate common protos #756

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Feb 7, 2024

This doesn't publish the common protos yet - I wanted to check whether we had anything else to include first.

Fixes b/324257950

@jskeet jskeet requested a review from a team as a code owner February 7, 2024 17:58
Copy link
Collaborator

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this all looks good.

- List top-level request fields to be auto-populated by
  client library generators
- Explicitly mark field_behavior as non-packed
@jskeet jskeet merged commit c2f7662 into googleapis:main Feb 7, 2024
4 checks passed
@jskeet jskeet deleted the regenerate branch February 9, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants