feat: Add a FieldFormats static class for auto-populated fields #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
added
the
do not merge
Google.Api.Gax/FieldGenerators.cs
Outdated
| /// <summary> | ||
| /// Generator methods for auto-populated fields. | ||
| /// </summary> | ||
| public static class FieldGenerators |
There was a problem hiding this comment.
FieldValueGenerators or ValueGenerators ? I think just Field is confusing, specially when quickly seen in generator code.
Is something other than value generation that we expect to be doing here? Validations are unlikely I guess. But maybe canonicalization? Just thinking whether we want FieldGenerators and the hypotethetical FieldCanonicalizations or simply FieldHelpers.
There was a problem hiding this comment.
Changed to FieldFormats.
Google.Api.Gax/FieldGenerators.cs
Outdated
|
|
||
| using System; | ||
|
|
||
| namespace Google.Api.Gax; |
There was a problem hiding this comment.
Yep, this is fine.
(I'd really like if we had a base package that both Apiaries and Gax/GAPICs could use, we'd then could put this kind of thing there (and WithCancellationToken :)). But that's something for another day.)
jskeet
force-pushed
the
field-generation
branch
from
eea877d to
6ceb87c
Compare
jskeet
changed the title
jskeet
removed
the
do not merge
amanda-tarafa
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/324254628