-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gensupport): per-chunk deadline configs #1414
Conversation
Allow users to configure the per-chunk deadline for retries that's used during resumable uploads. Needs to be exposed via the manual layer for storage. Fixes googleapis#685
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
// will be returned to the caller. | ||
// This is only applicable for files which are large enough to require | ||
// a multi-chunk resumable upload. | ||
// The default value is 32s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has 32s at per chunk been the default for a while now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 3ish years: 4fac4de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, and there was a default of 16s prior to that apparently.
feat(gensupport): per-chunk deadline configs
Allow users to configure the per-chunk deadline for retries
that's used during resumable uploads.
Needs to be exposed via the manual layer for storage.
Fixes #685