Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move storage, bigquery, and compute to new auth lib #2695

Merged
merged 2 commits into from
Jul 24, 2024
Merged

feat: move storage, bigquery, and compute to new auth lib #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dfa57f
feat: move storage, bigquery, and compute to new auth lib
codyoss Jul 24, 2024
aebbe38
regen changes
codyoss Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bigquery/v2/bigquery-gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions compute/v0.alpha/compute-gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions compute/v0.beta/compute-gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions compute/v1/compute-gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 2 additions & 12 deletions google-api-go-generator/gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,6 @@ var skipAPIGeneration = map[string]bool{
"datalineage:v1": true,
}

// skipNewAuthLibrary is a set of APIs to not migrate to cloud.google.com/go/auth.
var skipNewAuthLibrary = map[string]bool{
"bigquery:v2": true,
"compute:alpha": true,
"compute:beta": true,
"compute:v1": true,
"storage:v1": true,
}

var apisToSplit = map[string]bool{
"compute": true,
}
Expand Down Expand Up @@ -897,9 +888,8 @@ func (a *API) GenerateCode() ([]byte, error) {
if a.mtlsAPIBaseURL() != "" {
pn("opts = append(opts, internaloption.WithDefaultMTLSEndpoint(mtlsBasePath))")
}
if !skipNewAuthLibrary[a.ID] {
pn("opts = append(opts, internaloption.EnableNewAuthLibrary())")
}
pn("opts = append(opts, internaloption.EnableNewAuthLibrary())")

pn("client, endpoint, err := htransport.NewClient(ctx, opts...)")
pn("if err != nil { return nil, err }")
pn("s, err := New(client)")
Expand Down
1 change: 1 addition & 0 deletions storage/v1/storage-gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.