feat: add support for universe domain #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
4 tasks
generator/tests/testdata/golden/php/default/endpoints_google_owned.golden
Show resolved
Hide resolved
vishwarajanand
approved these changes
Feb 29, 2024
| @@ -331,8 +331,11 @@ def _NormalizeUrlComponents(self): | |||
| scheme = url_parts.scheme or 'https' | |||
| service_host = url_parts.netloc or _DEFAULT_SERVICE_HOST | |||
| base_path = url_parts.path | |||
| if not root_url: | |||
| if root_url: | |||
| self._api.SetTemplateValue('rootUrlTemplate', root_url.replace('googleapis.com', 'UNIVERSE_DOMAIN')) | |||
There was a problem hiding this comment.
This might break though, if users have a rooturl like:
usergoogleapis.com, it would be changed to userUNIVERSE_DOMAIN.
There was a problem hiding this comment.
I am not sure though how big of a usecase this is... a client using TPC and their domain name has googleapis.com
There was a problem hiding this comment.
we could replace .googleapis.com with .UNIVERSE_DOMAIN if you think that would be safer.
bshaffer
commented
Apr 23, 2024
bshaffer
force-pushed
the
universe-domain
branch
from
0d0bf65 to
6889d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds new
$rootUrlTemplateproperty to all service classes in order to support the universe domain option in googleapis/google-api-php-client#2563