chore: use assertEquals to improve test error message (#1470)

* chore: use assertEquals to improve test error message * chore: lint --------- Co-authored-by: Min Zhu <zhumin@google.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
googleapis · Aug 29, 2024 · d62d06e · d62d06e
1 parent e1b1a33
commit d62d06e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/oauth2_http/javatests/com/google/auth/oauth2/ExecutableResponseTest.java b/oauth2_http/javatests/com/google/auth/oauth2/ExecutableResponseTest.java
@@ -63,8 +63,8 @@ public void constructor_successOidcResponse() throws IOException {
     assertEquals(EXECUTABLE_SUPPORTED_MAX_VERSION, response.getVersion());
     assertEquals(TOKEN_TYPE_OIDC, response.getTokenType());
     assertEquals(ID_TOKEN, response.getSubjectToken());
-    assertTrue(
-        Instant.now().getEpochSecond() + EXPIRATION_DURATION == response.getExpirationTime());
+    assertEquals(
+        Instant.now().getEpochSecond() + EXPIRATION_DURATION, (long) response.getExpirationTime());
   }
 
   @Test
@@ -93,8 +93,8 @@ public void constructor_successSamlResponse() throws IOException {
     assertEquals(EXECUTABLE_SUPPORTED_MAX_VERSION, response.getVersion());
     assertEquals(TOKEN_TYPE_SAML, response.getTokenType());
     assertEquals(SAML_RESPONSE, response.getSubjectToken());
-    assertTrue(
-        Instant.now().getEpochSecond() + EXPIRATION_DURATION == response.getExpirationTime());
+    assertEquals(
+        Instant.now().getEpochSecond() + EXPIRATION_DURATION, (long) response.getExpirationTime());
   }
 
   @Test

diff --git a/oauth2_http/javatests/com/google/auth/oauth2/PluggableAuthHandlerTest.java b/oauth2_http/javatests/com/google/auth/oauth2/PluggableAuthHandlerTest.java
@@ -741,8 +741,8 @@ public void getExecutableResponse_oidcResponse() throws IOException, Interrupted
     assertTrue(response.isSuccessful());
     assertEquals(TOKEN_TYPE_OIDC, response.getTokenType());
     assertEquals(ID_TOKEN, response.getSubjectToken());
-    assertTrue(
-        Instant.now().getEpochSecond() + EXPIRATION_DURATION == response.getExpirationTime());
+    assertEquals(
+        Instant.now().getEpochSecond() + EXPIRATION_DURATION, (long) response.getExpirationTime());
     // Current env map should include the mappings from options.
     assertEquals(4, currentEnv.size());
     assertEquals(expectedMap, currentEnv);
@@ -788,8 +788,8 @@ public void getExecutableResponse_samlResponse() throws IOException, Interrupted
     assertTrue(response.isSuccessful());
     assertEquals(TOKEN_TYPE_SAML, response.getTokenType());
     assertEquals(SAML_RESPONSE, response.getSubjectToken());
-    assertTrue(
-        Instant.now().getEpochSecond() + EXPIRATION_DURATION == response.getExpirationTime());
+    assertEquals(
+        Instant.now().getEpochSecond() + EXPIRATION_DURATION, (long) response.getExpirationTime());
 
     // Current env map should include the mappings from options.
     assertEquals(4, currentEnv.size());