Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes AWS credential source validation. #1177

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: removes AWS credential source validation. #1177

merged 1 commit into from
Mar 6, 2023

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Mar 2, 2023

Removes the changes introduced by #1079.

@lsirac lsirac requested a review from a team as a code owner March 2, 2023 01:22
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 2, 2023
@lsirac lsirac requested a review from aeitzman March 2, 2023 01:23
@lsirac lsirac added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 2, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 2, 2023
TimurSadykov
TimurSadykov approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe also mention it in readme? Like previous removed validations

@TimurSadykov TimurSadykov added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 2, 2023
@lsirac lsirac merged commit 77a99c9 into googleapis:main Mar 6, 2023
@lsirac lsirac deleted the aws branch March 6, 2023 21:30
@release-please release-please bot mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeitzman aeitzman aeitzman approved these changes

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsirac @TimurSadykov @aeitzman @kokoro-team