-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: expose test-jar and mock classes in oauth2 #1224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarquezp
requested review from
TimurSadykov
and removed request for
TimurSadykov
June 21, 2023 14:24
blakeli0
approved these changes
Jun 21, 2023
oauth2_http/javatests/com/google/auth/oauth2/MockHttpTransportFactory.java
Outdated
Show resolved
Hide resolved
blakeli0
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to approve the PR, please resolve the comments before merging.
TimurSadykov
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
blakeli0
approved these changes
Jun 23, 2023
diegomarquezp
changed the title
test: expose test-jar and mock classes in oauth2
feat: expose test-jar and mock classes in oauth2
Jun 27, 2023
diegomarquezp
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
release-please:force-run
To run release-please
and removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jun 27, 2023
diegomarquezp
changed the title
feat: expose test-jar and mock classes in oauth2
test: expose test-jar and mock classes in oauth2
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to expose some test utils to be used in googleapis/sdk-platform-java#1642
Basically to allow
GdchCredentials
to be refreshed via fake transportBEGIN_COMMIT_OVERRIDE
feat: expose test-jar and mock classes in oauth2
END_COMMIT_OVERRIDE