Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message in case of problems with getting access token #206

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

dtretyakov
Copy link
Contributor

Currently in case of problems with token refresh is unclear what caused the problem and this change brings additional details.

Related to JetBrains/teamcity-google-storage#9

Currently it's unclear what caused the problem with it
@dtretyakov dtretyakov requested a review from a team as a code owner November 8, 2018 13:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
@dtretyakov
Copy link
Contributor Author

@chingor13, could you please take a look on it? It'll help to diagnose credentials-related problems.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, the original IOException is contained as the cause of the newly thrown one. If you catch the IOException you can call getCause() to get the original exception.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@eb7e845). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #206   +/-   ##
=========================================
  Coverage          ?   75.84%           
  Complexity        ?      313           
=========================================
  Files             ?       20           
  Lines             ?     1354           
  Branches          ?      148           
=========================================
  Hits              ?     1027           
  Misses            ?      254           
  Partials          ?       73
Impacted Files Coverage Δ Complexity Δ
.../google/auth/oauth2/ServiceAccountCredentials.java 81.38% <100%> (ø) 44 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7e845...0915929. Read the comment docs.

@chingor13 chingor13 merged commit cdcf589 into googleapis:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants