-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in ComputeEngineCredentials exception message #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typo fix makes sense, though looking at this code now I strongly suspect this is not something we should be doing. That exception should not be wrapped and definitely not into a runtime exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this!
Our test also appears to be validating the error message with the typo. Can you update the test cases as well?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, there's one more failed test
Done. Editing code on Github... :) |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
============================================
+ Coverage 78.42% 78.98% +0.55%
Complexity 336 336
============================================
Files 22 22
Lines 1460 1513 +53
Branches 158 158
============================================
+ Hits 1145 1195 +50
- Misses 237 240 +3
Partials 78 78
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.