Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Automatic-Module-Name to manifest (#324) #326

Merged
merged 4 commits into from
Aug 9, 2019
Merged

feat: add Automatic-Module-Name to manifest (#324) #326

merged 4 commits into from
Aug 9, 2019

Conversation

man0s
Copy link
Contributor

@man0s man0s commented Aug 9, 2019 •
edited by elharo
Loading

2/3 for #324
As stated in #325 by @elharo , Automatic-Module-Name need to be in submodules and not in parent.
lmk if everything is okay.

@man0s man0s requested a review from a team as a code owner August 9, 2019 15:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2019
elharo
elharo previously requested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Each module needs a different name. You can only use com.google.auth for one.
  2. Two space indents, per Google style.

chingor13
chingor13 requested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this!

bom/pom.xml Outdated Show resolved Hide resolved
appengine/pom.xml Outdated Show resolved Hide resolved
oauth2_http/pom.xml Outdated Show resolved Hide resolved
appengine/pom.xml Outdated Show resolved Hide resolved
@man0s
Copy link
Contributor Author

man0s commented Aug 9, 2019

Thanks @elharo & @chingor13 for the suggestions.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2019
@chingor13 chingor13 changed the title Automatic-Module-Name to manifest (#324) feat: add Automatic-Module-Name to manifest (#324) Aug 9, 2019
@chingor13 chingor13 merged commit 29f58b4 into googleapis:master Aug 9, 2019
elharo
elharo approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for these two. It's not a complete fix. We'll also need to do this for google-auth-library-java/credentials/ but we can commit this as is.

@chingor13 chingor13 mentioned this pull request Aug 9, 2019
Closed
@chingor13
Copy link
Contributor

The credentials module was included. It's the com.google.auth module as that artifact is providing classes in that root package.

@elharo
Copy link
Contributor

elharo commented Aug 9, 2019

My mistake. Sorry.

@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@man0s @chingor13 @elharo @googlebot @kokoro-team