Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: privatize deprecated constructor #473

Merged
merged 7 commits into from
Dec 21, 2020
Merged

fix!: privatize deprecated constructor #473

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2efc4b7
privatize deprecated method
elharo Aug 31, 2020
564d455
ignore removal of deprecated method
elharo Aug 31, 2020
ea7cb4a
api not locked down
elharo Aug 31, 2020
0a7e062
fix merge error
elharo Sep 17, 2020
d1d977c
move ignore file to submodule
elharo Sep 17, 2020
a9c148e
Merge branch 'master' into ae
chingor13 Dec 16, 2020
40af346
Merge branch 'master' into ae
elharo Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions oauth2_http/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- see https://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<difference>
<differenceType>7009</differenceType>
<className>com/google/auth/oauth2/ServiceAccountJwtAccessCredentials</className>
<method>ServiceAccountJwtAccessCredentials(java.lang.String, java.lang.String, java.security.PrivateKey, java.lang.String)</method>
<from>public</from>
<to>private</to>
</difference>
</differences>
5 changes: 1 addition & 4 deletions oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,8 @@ public class ServiceAccountJwtAccessCredentials extends Credentials
* @param clientEmail Client email address of the service account from the console.
* @param privateKey RSA private key object for the service account.
* @param privateKeyId Private key identifier for the service account. May be null.
* @deprecated Use {@link #newBuilder()} instead. This constructor will either be deleted or made
* private in a later version.
*/
@Deprecated
public ServiceAccountJwtAccessCredentials(
private ServiceAccountJwtAccessCredentials(
String clientId, String clientEmail, PrivateKey privateKey, String privateKeyId) {
this(clientId, clientEmail, privateKey, privateKeyId, null, null);
}
Expand Down