Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed javadoc errors #945

Merged
merged 10 commits into from
Oct 14, 2022
Merged

fix: fixed javadoc errors #945

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
43406eb
fix: fixed javadoc errors
aeitzman Jul 13, 2022
671fa3b
Merge branch 'main' into java-doc-fix
lsirac Jul 14, 2022
91ec326
Merge branch 'main' into java-doc-fix
lsirac Jul 26, 2022
b657f6e
Merge branch 'googleapis:main' into java-doc-fix
aeitzman Aug 3, 2022
525b55c
Merge branch 'main' into java-doc-fix
aeitzman Oct 5, 2022
89e55c8
Add missing @params and @return
aeitzman Oct 5, 2022
3791bed
linting fix
aeitzman Oct 12, 2022
024ffed
revert pom.xml changes
aeitzman Oct 12, 2022
2866af8
Merge branch 'main' into java-doc-fix
aeitzman Oct 12, 2022
160e703
Addressing PR comments
aeitzman Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oauth2_http/java/com/google/auth/oauth2/PluggableAuthCredentials.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,14 @@
* "code": "401",
* "message": "Error message."
* }
* </pre>
*
* The auth libraries will populate certain environment variables that will be accessible by the
* executable, such as: GOOGLE_EXTERNAL_ACCOUNT_AUDIENCE, GOOGLE_EXTERNAL_ACCOUNT_TOKEN_TYPE,
* GOOGLE_EXTERNAL_ACCOUNT_INTERACTIVE, GOOGLE_EXTERNAL_ACCOUNT_IMPERSONATED_EMAIL, and
* GOOGLE_EXTERNAL_ACCOUNT_OUTPUT_FILE.
*
* <p>Please see this repositories README for a complete executable request/response specification.
* </pre>
*/
public class PluggableAuthCredentials extends ExternalAccountCredentials {

Expand Down
15 changes: 8 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.4.0</version>
<configuration>
<source>7</source>
<source>8</source>
<doclint>all,-missing</doclint>
<failOnError>false</failOnError>
</configuration>
<executions>
Expand Down Expand Up @@ -332,7 +333,7 @@
<configuration>
<failOnError>false</failOnError>
<doclint>none</doclint>
<source>7</source>
<source>8</source>
<outputDirectory>${project.build.directory}/javadoc</outputDirectory>
<doctitle>Google Auth Library for Java ${project.version}</doctitle>
<overview>${basedir}/overview.html</overview>
Expand Down Expand Up @@ -479,7 +480,7 @@
<projectname>${project.artifactId}</projectname>
<excludeclasses></excludeclasses>
<excludePackages></excludePackages>
<source>7</source>
<source>8</source>
<sourceFileExclude></sourceFileExclude>
</properties>
<build>
Expand All @@ -494,9 +495,9 @@
<!-- custom config with -Dproperty=value -->
<docletPath>${env.KOKORO_GFILE_DIR}/${docletName}.jar</docletPath>
<additionalOptions>
-outputpath ${outputpath}
-projectname ${projectname}
-excludeclasses ${excludeclasses}:
-outputpath ${outputpath}
-projectname ${projectname}
-excludeclasses ${excludeclasses}:
-excludepackages ${excludePackages}:
</additionalOptions>
<doclint>none</doclint>
Expand All @@ -508,7 +509,7 @@
</sourceFileExcludes>
<failOnError>false</failOnError>
</configuration>
</plugin>
</plugin>
</plugins>
</build>
</profile>
Expand Down