Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the CHANGELOG to reflect 3.x breaking changes #671

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

JustinBeckwith
Copy link
Contributor

Fixes #613. There were errors in the changelog in the 3.0 release. I already cleaned up the release notes in the GitHub release.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2019
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          18       18           
  Lines         769      769           
  Branches       83       83           
=======================================
  Hits          679      679           
  Misses         79       79           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffd1cc...782813e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          18       18           
  Lines         769      769           
  Branches       83       83           
=======================================
  Hits          679      679           
  Misses         79       79           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffd1cc...782813e. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's make this not manual as soon as humanly possible 😄

@JustinBeckwith JustinBeckwith merged commit 8cc5522 into master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: v3.0.0 release has duplicate BREAKING headers
4 participants