Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect cache control for access token certs #479

Merged
merged 5 commits into from
Oct 10, 2023
Merged

feat: respect cache control for access token certs #479

merged 5 commits into from
Oct 10, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Sep 8, 2023

addresses #463

Extracts max-age from the Cache-Control header in order to set the cache lifetime of the certs.

@bshaffer bshaffer requested a review from a team as a code owner September 8, 2023 20:56
@bshaffer bshaffer mentioned this pull request Sep 8, 2023
Closed
ynikitin-etsy
ynikitin-etsy reviewed Sep 15, 2023
View reviewed changes
src/AccessToken.php Outdated Show resolved Hide resolved
ynikitin-etsy
ynikitin-etsy reviewed Sep 15, 2023
View reviewed changes
src/AccessToken.php Outdated Show resolved Hide resolved
ynikitin-etsy
ynikitin-etsy approved these changes Sep 15, 2023
View reviewed changes
Copy link

@ynikitin-etsy ynikitin-etsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for this!

vishwarajanand
vishwarajanand approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bshaffer bshaffer enabled auto-merge (squash) October 10, 2023 17:52
@bshaffer bshaffer merged commit 6d426b5 into main Oct 10, 2023
11 checks passed
@bshaffer bshaffer deleted the respect-cache-control branch October 10, 2023 17:52
@release-please release-please bot mentioned this pull request Oct 10, 2023
Merged
@vishwarajanand vishwarajanand mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ynikitin-etsy ynikitin-etsy ynikitin-etsy approved these changes

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @vishwarajanand @ynikitin-etsy