Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add StdOutLogger and LoggingTrait #578

Merged
merged 53 commits into from
Dec 11, 2024
Merged

feat: add StdOutLogger and LoggingTrait #578

merged 53 commits into from
Dec 11, 2024

Conversation

Hectorhammett
Copy link
Contributor

@Hectorhammett Hectorhammett commented Sep 4, 2024 •
edited
Loading

related: googleapis/gax-php#585

Add logging support to the HTTP calls for easy debugging.

@Hectorhammett Hectorhammett requested a review from a team as a code owner September 4, 2024 21:46
@bshaffer bshaffer changed the title Feat: Add the StdOutLogger and Logging Trait feat: add StdOutLogger and LoggingTrait Sep 5, 2024
@Hectorhammett Hectorhammett mentioned this pull request Sep 11, 2024
Merged
@Hectorhammett Hectorhammett marked this pull request as draft September 25, 2024 21:40
@Hectorhammett Hectorhammett mentioned this pull request Sep 27, 2024
Merged
bshaffer
bshaffer reviewed Oct 22, 2024
View reviewed changes
src/ApplicationDefaultCredentials.php Outdated Show resolved Hide resolved
src/ApplicationDefaultCredentials.php Outdated Show resolved Hide resolved
src/HttpHandler/Guzzle6HttpHandler.php Outdated Show resolved Hide resolved
src/HttpHandler/Guzzle6HttpHandler.php Outdated Show resolved Hide resolved
src/HttpHandler/Guzzle6HttpHandler.php Outdated Show resolved Hide resolved
src/Logging/LoggingTrait.php Outdated Show resolved Hide resolved
src/Logging/LoggingTrait.php Outdated Show resolved Hide resolved
src/Logging/StdOutLogger.php Outdated Show resolved Hide resolved
tests/Logging/StdOutLoggerTest.php Show resolved Hide resolved
src/ApplicationDefaultCredentials.php Outdated Show resolved Hide resolved
@Hectorhammett
Add the StdOutLogger and Logging Trait
5de2301
@Hectorhammett
Fix types and style
f393157
@Hectorhammett
fix typing for PSR-3 logger interface
e5540f6
@Hectorhammett
Add logging to the Guzzle6HttpHandler
ff21a95
@Hectorhammett
Change logic for getDefaultLogger
0c65a32
@Hectorhammett
Fix style issues
8c7c101
@Hectorhammett
Fix phpstan typing for getJwtToken
301d28e
@Hectorhammett
Add a flag for disabling logger
5ae7c1e
@Hectorhammett
Add logging to the invoke method for apiary support
7aa7ee2
@Hectorhammett
Fix style issue on build method
331e97c
@Hectorhammett
Change logic for disabling logging
35f8dde
@Hectorhammett
Fix logic for disabling logging
36fd1ac
@Hectorhammett
Add a function to log a gRPC status only
2ff7d1a
@Hectorhammett
Removed unused method
dbfb61c
@Hectorhammett
Fix style for LoggingTrait
2f87636
@Hectorhammett
Fix typing
0cb0c27
@Hectorhammett
Updated type annotations
8e4a7e5
@Hectorhammett
Change logic for logging responses to exclude the info log
6ca6bc7
@Hectorhammett
Change logic for logResponse
16d9372
@Hectorhammett
Handle false for the case when json_encode returns false
b1ff503
@Hectorhammett Hectorhammett marked this pull request as ready for review December 5, 2024 22:47
bshaffer
bshaffer reviewed Dec 5, 2024
View reviewed changes
src/ApplicationDefaultCredentials.php Show resolved Hide resolved
src/HttpHandler/Guzzle6HttpHandler.php Outdated Show resolved Hide resolved
src/HttpHandler/Guzzle6HttpHandler.php Outdated Show resolved Hide resolved
bshaffer
bshaffer reviewed Dec 11, 2024
View reviewed changes
src/ApplicationDefaultCredentials.php Outdated Show resolved Hide resolved
src/ApplicationDefaultCredentials.php Outdated Show resolved Hide resolved
src/ApplicationDefaultCredentials.php Outdated Show resolved Hide resolved
src/HttpHandler/Guzzle6HttpHandler.php Show resolved Hide resolved
src/HttpHandler/Guzzle6HttpHandler.php Outdated Show resolved Hide resolved
src/Logging/LoggingTrait.php Outdated Show resolved Hide resolved
tests/ApplicationDefaultCredentialsTest.php Outdated Show resolved Hide resolved
tests/HttpHandler/Guzzle7HttpHandlerTest.php Outdated Show resolved Hide resolved
tests/HttpHandler/Guzzle7HttpHandlerTest.php Show resolved Hide resolved
tests/Logging/LoggingTraitTest.php Outdated Show resolved Hide resolved
@Hectorhammett Hectorhammett merged commit 4f793fe into main Dec 11, 2024
13 checks passed
@Hectorhammett Hectorhammett deleted the http-logging branch December 11, 2024 00:52
@release-please release-please bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hectorhammett @bshaffer