chore(deps): update Bazel to v7 #13274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
force-pushed
the
chore-update-bazel-7
branch
from
1678e88
to
97c282f
Compare
coryan
force-pushed
the
chore-update-bazel-7
branch
from
4bcb8c5
to
fd928cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13274 +/- ##
==========================================
- Coverage 93.06% 93.05% -0.01%
==========================================
Files 2140 2140
Lines 186610 186610
==========================================
- Hits 173661 173659 -2
- Misses 12949 12951 +2 ☔ View full report in Codecov by Sentry. |
keith
reviewed
Dec 14, 2023
.bazelrc
Outdated
| # TODO(#11485) - enable bzlmod once it works | ||
| common --noenable_bzlmod | ||
|
|
||
| # TODO(#....) - apparently Bazel on macOS still needs work. |
There was a problem hiding this comment.
I would reframe this to point to any grpc issue about not requiring rules you're not using. AFAIUI your case things are working as expected. Either you register the default toolchain first, you require users to have Xcode, or you remove apple_support, the later seems like the best solution for reducing your maintenance cost assuming grpc allowed you to only include what you need.
WIP - need to load more deps WIP - update Bazel version Disable bzlmod WIP - only need rules_apple Fix formatting Cache rules_apple Fix 'verify' directories Fix quickstarts Disable bzlmod on quickstarts Use the same TODO for all bzlmod flags WIP - more output on Windows Working on macOS Same edits for all other WORKSPACE files Fix build scripts And reorder stuff Argh, variables, how do they work? WIP - use common args in bazel info Revert quickstart changes Actually print the Bazel info Fix some checkers Fix TODO Keep quickstart build at Bazel 6.4.0 For realsies this time
coryan
force-pushed
the
chore-update-bazel-7
branch
from
5ee89c0
to
486d81e
Compare
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Dec 15, 2023
This reverts commit bb6dc52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is