Skip to content

Commit

Permalink
storage: don't fail tests loudly if cleanup fails
Browse files Browse the repository at this point in the history
It seems that our integration tests are failing fairly frequently
because we are trying to delete an object which has already been
deleted.

Change-Id: I5861574bb693e16e94b96a81445576429af99b8b
Reviewed-on: https://code-review.googlesource.com/8430
Reviewed-by: Ross Light <light@google.com>
  • Loading branch information
Sarah Adams committed Oct 13, 2016
1 parent 139d2e0 commit fa279f9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion storage/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ func TestMain(m *testing.M) {
exit := m.Run()
if integrationTest {
if err := cleanup(); err != nil {
log.Fatalf("Post-test cleanup failed: %v", err)
// No need to be loud if cleanup() fails; we'll get
// any undeleted buckets next time.
log.Printf("Post-test cleanup failed: %v\n", err)
}
}
os.Exit(exit)
Expand Down

0 comments on commit fa279f9

Please sign in to comment.