Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: many tests failed #4156

Closed
flaky-bot bot opened this issue May 24, 2021 · 5 comments · Fixed by #4169
Closed

spanner: many tests failed #4156

flaky-bot bot opened this issue May 24, 2021 · 5 comments · Fixed by #4169
Assignees
@hengfengli
Labels
api: spanner Issues related to the Spanner API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 24, 2021

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

  • TestPartitionRoundTrip
  • TestBROTIDRoundTrip
  • TestPartitionQuery_QueryOptions/Query_level_has_highest_precedence
  • TestPartitionQuery_Parallel
  • TestClient_Single
  • TestClient_Single_Unavailable
  • TestClient_Single_InvalidArgument
  • TestClient_Single_SessionNotFound
  • TestClient_Single_Read_SessionNotFound
  • TestClient_Single_ReadRow_SessionNotFound
  • TestClient_Single_RetryableErrorOnPartialResultSet
  • TestClient_Single_NonRetryableErrorOnPartialResultSet
  • TestClient_Single_NonRetryableInternalErrors
  • TestClient_Single_DeadlineExceeded_NoErrors
  • TestClient_Single_DeadlineExceeded_WithErrors
  • TestClient_Single_ContextCanceled_noDeclaredServerErrors
  • TestClient_Single_ContextCanceled_withDeclaredServerErrors
  • TestClient_Single_QueryOptions/Client_level

commit: d5e59f1
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 24, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label May 24, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented May 24, 2021

119 tests failed in this package for commit f9cda8f (Build Status, Sponge).

commit: f9cda8f
buildURL: Build Status, Sponge
status: failed

@hengfengli
Copy link
Contributor

This should be fixed by #4155. @codyoss Why does it happen again?

@codyoss
Copy link
Member

codyoss commented May 25, 2021

Looking at the most recent post from flaky-bot it looks like there is really only one test failure left:

--- FAIL: TestSessionCreationIsDistributedOverChannels (0.03s)
panic: reflect: call of reflect.Value.Elem on zero Value [recovered]
	panic: reflect: call of reflect.Value.Elem on zero Value

goroutine 6803 [running]:
testing.tRunner.func1(0xc002cfb200)
	/usr/local/go/src/testing/testing.go:792 +0x6a7
panic(0x10573c0, 0xc000440560)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
reflect.Value.Elem(0x0, 0x0, 0x0, 0x116e41a, 0x8, 0x0)
	/usr/local/go/src/reflect/value.go:805 +0x39c
cloud.google.com/go/spanner.getSessionsPerChannel(0xc0039bad00, 0x0)
	/tmpfs/src/google-cloud-go/spanner/session_test.go:1981 +0x1f5
cloud.google.com/go/spanner.TestSessionCreationIsDistributedOverChannels(0xc002cfb200)
	/tmpfs/src/google-cloud-go/spanner/session_test.go:1935 +0x24f
testing.tRunner(0xc002cfb200, 0x11a4c18)
	/usr/local/go/src/testing/testing.go:827 +0x163
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:878 +0x65a
FAIL	cloud.google.com/go/spanner	114.275s

I think this is unrelated from the backend changes in the gapic layer, please let me know if I am wrong though!

@hengfengli
Copy link
Contributor

@olavloite Do you have any idea about this failed test?

olavloite added a commit that referenced this issue May 25, 2021
@olavloite
test(spanner): fix test case using reflection
bc5a3f8 
The refactoring of the generated gapic client had broken a test case
that used reflection to get an internal value. This fixes the test
by first getting the (new) internalClient, and then getting the value
from the internal client.

Fixes #4156
@olavloite olavloite mentioned this issue May 25, 2021
Merged
@olavloite
Copy link
Contributor

@olavloite Do you have any idea about this failed test?

Yes, this test case uses reflection to get to an internal value, and the refactoring of the generated client had changed the internal structure of the client and the fields that it was getting. I've updated the test case to reflect the new structure in #4169.

hengfengli pushed a commit that referenced this issue May 25, 2021
@olavloite
test(spanner): fix test case using reflection (#4169)
8bd87cb 
The refactoring of the generated gapic client had broken a test case
that used reflection to get an internal value. This fixes the test
by first getting the (new) internalClient, and then getting the value
from the internal client.

Fixes #4156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(spanner): fix test case using reflection googleapis/google-cloud-go
3 participants
@hengfengli @olavloite @codyoss