-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore): Adding vector search #10548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
Issues related to the Firestore API.
label
Jul 15, 2024
jba
requested changes
Jul 15, 2024
Thanks for the extensive tests! |
jba
requested changes
Jul 16, 2024
jba
requested changes
Jul 17, 2024
jba
reviewed
Jul 18, 2024
cindy-peng
reviewed
Jul 19, 2024
cindy-peng
reviewed
Jul 19, 2024
jba
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close! Some minor tweaks.
bhshkh
force-pushed
the
feature/fs-vector-search
branch
from
July 22, 2024 15:45
f93dcd4
to
b6f5f25
Compare
jba
approved these changes
Jul 22, 2024
bhshkh
force-pushed
the
feature/fs-vector-search
branch
from
July 22, 2024 19:51
0a13793
to
6db828c
Compare
cindy-peng
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/346827360
Python and Nodejs already have support for vector search. More details can be found here
This PR introduces the same functionality in Go client library.
Sample Usage:
Save documents with vector field:
FindNearest query:
The above query will return Excelsa and Arabica beans
Major changes: