feat(bigtable): Add UpdateFamily to allow updating a family type #10759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
|
Please resolve vet failures |
|
Please add description to the PR |
bhshkh
reviewed
Aug 23, 2024
| ignoreWarnings bool | ||
| } | ||
|
|
||
| // GCPolicyOption is the interface to change GC policy settings | ||
| type GCPolicyOption interface { |
There was a problem hiding this comment.
Ideally, we try to avoid modifying already exported and released types. This would break customer's code
https://pkg.go.dev/cloud.google.com/go/bigtable#GCPolicyOption
But I would like to know what any of the admins think
There was a problem hiding this comment.
I agree. I would suggest just updating the documentation.
done |
Done |
bhshkh
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently only possible to update a column GC policy. We want to be able to also update the value_type of a column family.