feat(storage/transfermanager): add SkipIfExists option #10893
Merged
+121
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
frankyn
reviewed
Sep 23, 2024
| t.Errorf("result.Err: %v", got.Err) | ||
| } | ||
|
|
||
| if strings.EqualFold(got.Object, "dir/objA") { |
There was a problem hiding this comment.
This only checks dir/objA, do you want to check the other included objects?
|
|
||
| // Now attempt to download the entire directory. | ||
| // The existing files should be skipped. | ||
| callbacks := make(chan bool) |
There was a problem hiding this comment.
It would help to clarify that you're checking that SkipIfExists() should not attempt downloading included files from previous directory download;
// In lex order we have:
// "dir/nested/again/obj1", -- included
// "dir/nested/objA", -- skipped
// "dir/file" -- included
// "dir/objA", -- skipped
// "dir/objB", -- skipped
// "dir/objC", -- included
There was a problem hiding this comment.
I added a comment here and put those objects in a variable - does that seem sufficient here?
| case <-done: | ||
| break | ||
| case <-callbacks: | ||
| gotCallbacks++ |
There was a problem hiding this comment.
For my learning, gotCallbacks is synchronized; so the directory download which uses a mutex could be rewritten this way. Is that correct?
There was a problem hiding this comment.
Correct. I re-wrote that logic, PTAL.
frankyn
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.