Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): fixup some docs #11023

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Oct 23, 2024

  • Added a missing godoc link
  • Simplified NewCachedTokenProvider to not explain what the CachedTokenProviderOptions already do.
  • removed the word stale from doc as that refers to internal state of a token that is not otherwise expressed in documentation.

Internal Bugs: 372880552, 372881290, 372879789

- Added a missing godoc link
- Simplified NewCachedTokenProvider to not explain what the
  CachedTokenProviderOptions already do.
- removed the word stale from doc as that refers to internal state
  of a token that is not otherwise expressed in documentation.

Internal Bugs: 372880552, 372881290, 372879789
@codyoss codyoss requested a review from a team as a code owner October 23, 2024 18:47
@codyoss codyoss added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2024
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit e5bec20 into googleapis:main Oct 25, 2024
7 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants