Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update oauth2adapt #11195

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Nov 26, 2024

Need newer version of oauth2adapt in google-api-go-client but currently it pulls in old one

bahaaiman@xxx:~/Documents/google-api-go-client$ go mod graph | grep oauth2adapt@v0.2.4
cloud.google.com/go@v0.116.0 cloud.google.com/go/auth/oauth2adapt@v0.2.4
bahaaiman@xxx:~/Documents/google-api-go-client$ 

@bhshkh bhshkh requested a review from a team as a code owner November 26, 2024 19:16
@codyoss codyoss changed the title chore(all): Update oauth2adapt chore: Update oauth2adapt Nov 26, 2024
@codyoss
Copy link
Member

codyoss commented Nov 26, 2024

This just updates the base mod, this does not make the change happen everywhere. The best way to roll this out to all is make sure the change is in google.golang.org/api, release that, and update that dep everywhere

@bhshkh bhshkh enabled auto-merge (squash) November 26, 2024 19:20
@bhshkh bhshkh merged commit 03551ae into googleapis:main Nov 26, 2024
9 of 10 checks passed
@bhshkh bhshkh deleted the chore/new-version-oauth2adapt branch November 27, 2024 20:10
@bhshkh
Copy link
Contributor Author

bhshkh commented Nov 27, 2024

This just updates the base mod, this does not make the change happen everywhere. The best way to roll this out to all is make sure the change is in google.golang.org/api, release that, and update that dep everywhere

When I try to update in google.golang.org/api, its pulling in the old version from cloud.google.com/go@v0.116.0 :

bahaaiman@xxx:~/Documents/google-api-go-client$ go mod graph | grep oauth2adapt@v0.2.4
cloud.google.com/go@v0.116.0 cloud.google.com/go/auth/oauth2adapt@v0.2.4
bahaaiman@xxx:~/Documents/google-api-go-client$ 

Will use 0.117.0 in google-api-go-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants