Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spanner): skip/remove oc span related tests #11260

Merged
merged 2 commits into from
Dec 10, 2024
+3 −18
Merged

test(spanner): skip/remove oc span related tests #11260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b53433
test(spanner): skip/remove oc span related tests
codyoss Dec 10, 2024
8773b18
Merge branch 'main' into oc-spanner-fix
codyoss Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions spanner/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5028,6 +5028,7 @@ func transactionOptionsTestCases() []TransactionOptionsTestCase {
}

func TestClient_DoForEachRow_ShouldNotEndSpanWithIteratorDoneError(t *testing.T) {
t.Skip("open census spans are no longer exported by gapics")
// This test cannot be parallel, as the TestExporter does not support that.
te := itestutil.NewTestExporter()
defer te.Unregister()
Expand Down Expand Up @@ -5072,6 +5073,7 @@ func TestClient_DoForEachRow_ShouldNotEndSpanWithIteratorDoneError(t *testing.T)
}

func TestClient_DoForEachRow_ShouldEndSpanWithQueryError(t *testing.T) {
t.Skip("open census spans are no longer exported by gapics")
// This test cannot be parallel, as the TestExporter does not support that.
te := itestutil.NewTestExporter()
defer te.Unregister()
Expand Down Expand Up @@ -5902,6 +5904,7 @@ func checkBatchWriteSpan(t *testing.T, errors []error, code codes.Code) {
}
}
func TestClient_BatchWrite_SpanExported(t *testing.T) {
t.Skip("open census spans are no longer exported by gapics")
testcases := []struct {
name string
code codes.Code
Expand Down
18 changes: 0 additions & 18 deletions spanner/oc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,6 @@ import (
structpb "google.golang.org/protobuf/types/known/structpb"
)

// Check that stats are being exported.
func TestOCStats(t *testing.T) {
DisableGfeLatencyAndHeaderMissingCountViews()
te := testutil.NewTestExporter()
defer te.Unregister()

_, c, teardown := setupMockedTestServer(t)
defer teardown()

c.Single().ReadRow(context.Background(), "Users", Key{"alice"}, []string{"email"})
// Wait until we see data from the view.
select {
case <-te.Stats:
case <-time.After(1 * time.Second):
t.Fatal("no stats were exported before timeout")
}
}

func TestOCStats_SessionPool(t *testing.T) {
skipUnsupportedPGTest(t)
DisableGfeLatencyAndHeaderMissingCountViews()
Expand Down
Loading