Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): add extra field to ignore with cmp and use testEqual #2583

Merged
merged 2 commits into from
Jul 10, 2020
Merged

fix(spanner): add extra field to ignore with cmp and use testEqual #2583

merged 2 commits into from
Jul 10, 2020

Conversation

hengfengli
Copy link
Contributor

Fixes #2582

@hengfengli hengfengli added the api: spanner Issues related to the Spanner API. label Jul 10, 2020
@hengfengli hengfengli requested a review from olavloite July 10, 2020 04:58
@hengfengli hengfengli requested a review from skuruppu as a code owner July 10, 2020 04:58
@hengfengli hengfengli self-assigned this Jul 10, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
@hengfengli hengfengli changed the title spanner: fix the upgrade of protobuf. fix(spanner): add extra field to ignore with cmp Jul 10, 2020
@hengfengli hengfengli changed the title fix(spanner): add extra field to ignore with cmp fix(spanner): add extra field to ignore with cmp and update to use testEqual Jul 10, 2020
@hengfengli hengfengli changed the title fix(spanner): add extra field to ignore with cmp and update to use testEqual fix(spanner): add extra field to ignore with cmp and use testEqual Jul 10, 2020
@codyoss
Copy link
Member

codyoss commented Jul 10, 2020

Whoops, sorry missed this one yesterday. Kicking off a build against this to make sure this is the last of the issues.

@codyoss codyoss merged commit 91ceec2 into googleapis:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@olavloite olavloite Awaiting requested review from olavloite

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner: many tests failed
3 participants
@hengfengli @codyoss @googlebot