Revert "feat(spanner): enable request options for batch read" #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
skuruppu
approved these changes
Apr 22, 2021
BREAKING CHANGE: Removes - BatchReadOnlyTransaction.PartitionReadUsingIndexWithOptions - BatchReadOnlyTransaction.PartitionReadWithOptions This reverts commit 0c73db2.
olavloite
force-pushed
the
revert-3905-spanner-enable-request-options-for-batch-read
branch
from
c225ddf
to
49ef511
Compare
|
@skuruppu The build is failing because it (correctly) detects that this is a breaking change. We are removing two exported methods that were added by the original change. I've updated the commit message so the api checker should accept this. |
olavloite
deleted the
revert-3905-spanner-enable-request-options-for-batch-read
branch
olavloite
added a commit
that referenced
this pull request
Jun 29, 2021
jschaf
pushed a commit
to jschaf/spanner-go
that referenced
this pull request
Oct 10, 2024
Reverts googleapis/google-cloud-go#3987 (Reverts the revert of #3905)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removes
BatchReadOnlyTransaction.PartitionReadUsingIndexWithOptionsandBatchReadOnlyTransaction.PartitionReadWithOptionsReverts #3905