chore(internal): gen googleapis-discovery compute genproto #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
@noahdietz Can can you rebase this PR now that regen should be unblocked. |
noahdietz
force-pushed
the
genproto-compute
branch
from
773ea23
to
7ce0c8d
Compare
Done! |
codyoss
reviewed
Jun 24, 2021
| }) | ||
| } | ||
| // TODO(noahdietz): This needs to be generalized to support any proto in googleapis-discovery. |
There was a problem hiding this comment.
We can change the format of the file to have several commits to track if necessary as this is all hand-rolled(no pattern to follow).
There was a problem hiding this comment.
Yeah, I think we may have to eventually. I'm not sure the googleapis-discovery pipeline is fully automated yet, so it's not urgent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcodes go-genproto generation for google/cloud/compute/v1 from googleapis-discovery. We will need to figure out how we support other protos in that repo in the future.
Note: This deos not add gapic gen for compute yet.
Note:
compute.pb.gois approximately 158k LoC 😮 .cc: @vchudnov-g @software-dov