fix(pubsublite): wire user context to api clients #4318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the context provided for
New(Publisher|Subscriber)Client
through to gapic clients. This will allow users to pass through a cancelable context, which they can use to quickly terminate the publisher and subscriber clients. This will give users more options to handle various scenarios (e.g. force immediate shutdown, hanging clients).It was originally not passed through to ensure that we can perform graceful shutdown (e.g. flush pending published. messages, commit cursors, etc), but there are situations where attempts to connect to the server can have long delays.
All other libraries just pass the context provided to the NewClient constructors through to the gapic clients, so we'll be consistent.