Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/storage/managedwriter): add opencensus instrumentation #4512

Merged

Conversation

shollyman
Copy link
Contributor

This starts to plumb in oc instrumentation, as we're already using it in
bigquery proper and other veneers.

Testing instrumentation helped catch another double-close in the recv processor, so this
addresses that as well.

Towards #4366

This starts to plumb in oc instrumentation, as we're already using it in
bigquery proper and other veneers.

Testing instrumentations helped catch another double-close in the recv processor, so this
addresses that as well.
@shollyman shollyman requested a review from a team as a code owner July 28, 2021 23:07
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jul 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2021
@shollyman shollyman requested a review from codyoss July 29, 2021 05:30
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 73b6f5e into googleapis:master Jul 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2021
@shollyman shollyman deleted the fr-managedwriter-opencensus branch July 30, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants