test(storage): add test for uploading with an emulator #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable seems to be duplicating information which led to a bug.
…into remove-envhost
You can now use the client library with an emulator by setting the environment variable to a host, with or without a scheme You also no longer have to supply an endpoint to use the emulator; the endpoint is built for you
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
tritone
reviewed
Aug 19, 2021
storage/storage_test.go
Outdated
| } | ||
| ctx := context.Background() | ||
| for _, tc := range testCases { | ||
| os.Setenv("STORAGE_EMULATOR_HOST", tc.StorageEmulatorHost) |
There was a problem hiding this comment.
This will change the value of the env var on the system (and mess up subsequent integration tests). You should capture the existing value for this in a variable and defer a call to restore the value to what it originally was.
There was a problem hiding this comment.
I think that's what I'm doing on line 1368 and 1369
…google-cloud-go into add-emulator-ops-test
tritone
reviewed
Aug 20, 2021
tritone
approved these changes
Aug 27, 2021
| case <-timeout: | ||
| t.Errorf("test timeout") | ||
| timedOut <- true | ||
| case <-done: |
There was a problem hiding this comment.
Probably could've used a WaitGroup (this is fine though!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test should catch an error such as #2476
Also added tests to ensure endpoint overrides emulator host when host is specified as host:port or scheme://host:port - this adds extra coverage to ensure something like #4444 does not occur again