Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add trace instrumentation support for individual rpcs #6493

Merged
merged 12 commits into from
Sep 2, 2022
Merged

feat(bigquery): add trace instrumentation support for individual rpcs #6493

merged 12 commits into from
Sep 2, 2022

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Aug 9, 2022 •
edited
Loading

This PR adds further opentelemetry trace instrumentation. Specifically, it adds span information for individual rpc-level retries.

This PR also adds two new callsites where we add retry support:

  • dataset deletion
  • job listing

@shollyman
feat(bigquery): add trace instrumentation support for individual rpcs
1da52cb 
This PR instruments the unary RPCs, with the exceptions of:
* job-related RPCs
* iterator-based RPCs (e.g. *.list operations)

This also adds retries for datasets.delete.
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the BigQuery API. labels Aug 9, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 31, 2022
@shollyman shollyman marked this pull request as ready for review August 31, 2022 21:12
@shollyman shollyman requested a review from a team August 31, 2022 21:12
@shollyman shollyman requested a review from a team as a code owner August 31, 2022 21:12
@alvarowolfx
Copy link
Contributor

Out of curiosity, how do you usually test those changes related to tracing ? Do you run a local app pointing to Stackdriver, use some local stack for tracing like Jaeger or other options ?

alvarowolfx
alvarowolfx approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman
Copy link
Contributor Author

Out of curiosity, how do you usually test those changes related to tracing ? Do you run a local app pointing to Stackdriver, use some local stack for tracing like Jaeger or other options ?

Good point, and thanks for keeping me honest. Added a new integration test for tracing. And good news, it highlighted other issues which have been addressed.

@shollyman shollyman enabled auto-merge (squash) September 2, 2022 04:14
@shollyman shollyman merged commit eedc632 into googleapis:main Sep 2, 2022
@release-please release-please bot mentioned this pull request Sep 2, 2022
Merged
This was referenced Sep 13, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarowolfx alvarowolfx alvarowolfx approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shollyman @alvarowolfx