Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): Add Iceberg as DataFormat option. #7155

Merged
merged 3 commits into from
Apr 6, 2023
Merged

feat(bigquery): Add Iceberg as DataFormat option. #7155

merged 3 commits into from
Apr 6, 2023

Conversation

emkornfield
Copy link
Contributor

Adds iceberg as a source format

@emkornfield emkornfield requested a review from a team December 10, 2022 04:53
@emkornfield emkornfield requested a review from a team as a code owner December 10, 2022 04:53
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 10, 2022
@emkornfield
Copy link
Contributor Author

CC @shollyman

emkornfield
emkornfield commented Dec 10, 2022
View reviewed changes
Copy link
Contributor Author

@emkornfield emkornfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix spacing.

@alvarowolfx alvarowolfx self-requested a review December 12, 2022 15:06
shollyman
shollyman approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine. Anywhere else we'll be emitting potential iceberg info, like load/export stats?

@codyoss codyoss changed the title feat: Add Iceberg as DataFormat option. feat(bigquery): Add Iceberg as DataFormat option. Dec 12, 2022
@emkornfield
Copy link
Contributor Author

There shouldn't be anything special for iceberg for loads/exports (just another table format).

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Dec 13, 2022
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jan 9, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Feb 8, 2023
@shollyman shollyman requested a review from a team as a code owner April 6, 2023 18:20
@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Apr 6, 2023
@shollyman
Copy link
Contributor

this fell off the radar. looks like it synced cleanly, set for automerge

@gcf-merge-on-green gcf-merge-on-green bot merged commit 7a9e211 into googleapis:main Apr 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 6, 2023
@release-please release-please bot mentioned this pull request Apr 6, 2023
Merged
This was referenced Apr 25, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@shollyman shollyman shollyman approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emkornfield @shollyman @alvarowolfx