chore(storage): add GCSFuse client config [benchmarking] #8225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
tritone
reviewed
Jul 6, 2023
product-auto-label
bot
added
size: m
raj-prince
reviewed
Jul 7, 2023
raj-prince
reviewed
Jul 7, 2023
raj-prince
reviewed
Jul 7, 2023
raj-prince
reviewed
Jul 7, 2023
| if err == nil { | ||
| http2Trans.ReadIdleTimeout = time.Second * 31 | ||
| if config.setGCSFuseOpts { | ||
| base = &http.Transport{ |
There was a problem hiding this comment.
We don't need to create another object, since we are cloning the transport object in line:190. We can just override the attributes. Like,
base.MaxConnsPerHost = 100
base.MaxIdleConnsPerHost = 100
base.TLSNextProto = make(map[string]func(string, *tls.Conn) http.RoundTripper)
There was a problem hiding this comment.
I'd rather keep the exact initialization code as gcsFuse has. http.DefaultTransport configures several transport variables to default values, and I'm not sure manually initializing an http.Transport would have those configured the same.
raj-prince
suggested changes
Jul 7, 2023
raj-prince
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.