build!: update library to use Node 12 (#524)

* build!: Update library to use Node 12 Co-authored-by: Summer Ji <summerji@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · May 20, 2022 · 7341476 · 7341476
1 parent 37d538b
commit 7341476
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/packages/google-cloud-dns/package.json b/packages/google-cloud-dns/package.json
@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": ">=10"
+    "node": ">=12.0.0"
   },
   "repository": "googleapis/nodejs-dns",
   "main": "./build/src/index.js",
@@ -67,10 +67,10 @@
     "jsdoc-fresh": "^1.0.1",
     "jsdoc-region-tag": "^1.0.2",
     "linkinator": "^2.0.0",
-    "mocha": "^8.0.0",
+    "mocha": "^9.2.2",
     "proxyquire": "^2.0.1",
     "tmp": "^0.2.0",
-    "typescript": "^3.8.3",
+    "typescript": "^4.6.4",
     "uuid": "^8.0.0"
   }
 }
diff --git a/packages/google-cloud-dns/samples/package.json b/packages/google-cloud-dns/samples/package.json
@@ -5,7 +5,7 @@
   "author": "Google Inc.",
   "repository": "googleapis/nodejs-dns",
   "engines": {
-    "node": ">=10"
+    "node": ">=12.0.0"
   },
   "files": [
     "*.js",
@@ -22,4 +22,4 @@
     "mocha": "^8.0.0",
     "uuid": "^8.0.0"
   }
-}
+}
diff --git a/packages/google-cloud-dns/test/record.ts b/packages/google-cloud-dns/test/record.ts
@@ -20,6 +20,11 @@ import * as proxyquire from 'proxyquire';
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 import {Record} from '../src';
 
+interface Metadata {
+  name: string;
+  data?: string[];
+  ttl: number;
+}
 let promisified = false;
 const fakePromisify = Object.assign({}, promisify, {
   promisifyAll(esClass: Function, options: promisify.PromisifyAllOptions) {
@@ -292,7 +297,7 @@ describe('Record', () => {
   });
 
   describe('delete', () => {
-    it('should call zone.deleteRecords', done => {
+    it('should call zone.deleteRecords', (done: any) => {
       record.zone_.deleteRecords = (records: Record[], callback: Function) => {
         assert.strictEqual(records, record);
         callback();
@@ -303,7 +308,7 @@ describe('Record', () => {
 
   describe('toJSON', () => {
     it('should format the data for the API', () => {
-      const expectedRecord = Object.assign({}, METADATA, {
+      const expectedRecord: Metadata = Object.assign({}, METADATA, {
         type: 'A',
         rrdatas: METADATA.data,
       });