Skip to content

Commit

Permalink
fix(types): use Metadata type instead of r.Response (#266)
Browse files Browse the repository at this point in the history
  • Loading branch information
JustinBeckwith authored May 23, 2019
1 parent b661214 commit 9b91d46
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/google-cloud-dns/src/record.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ import {promisifyAll} from '@google-cloud/promisify';
import arrify = require('arrify');
import {Change, CreateChangeCallback} from './change';
import {Zone} from './zone';
import {Metadata} from '@google-cloud/common';

const format = require('string-format-obj');
import * as r from 'request';

export interface RecordObject {
rrdatas?: Array<{}>;
Expand All @@ -42,7 +42,7 @@ export interface RecordMetadata {
* @property {Change} 0 A {@link Change} object.
* @property {object} 1 The full API response.
*/
export type DeleteRecordResponse = [Change, r.Response];
export type DeleteRecordResponse = [Change, Metadata];

/**
* @callback DeleteRecordCallback
Expand All @@ -51,7 +51,7 @@ export type DeleteRecordResponse = [Change, r.Response];
* @param {object} apiResponse The full API response.
*/
export interface DeleteRecordCallback {
(err: Error | null, change?: Change, apiResponse?: r.Response): void;
(err: Error | null, change?: Change, apiResponse?: Metadata): void;
}

/**
Expand Down

0 comments on commit 9b91d46

Please sign in to comment.