Merge pull request #961 from stephenplusplus/spp--storage-file-genera…

…tions-can-be-strings storage: generations are returned as strings
googleapis · Nov 25, 2015 · 9d676fc · 9d676fc
2 parents 9681a03 + fbbac14
commit 9d676fc
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/lib/storage/file.js b/lib/storage/file.js
@@ -114,11 +114,12 @@ function File(bucket, name, options) {
     value: name
   });
 
+  var generation = parseInt(options.generation, 10);
   var requestQueryObject = {};
 
-  if (is.number(options.generation)) {
-    requestQueryObject.generation = options.generation;
-    this.generation = options.generation;
+  if (!isNaN(generation)) {
+    requestQueryObject.generation = generation;
+    this.generation = generation;
   }
 
   var methods = {
@@ -372,7 +373,7 @@ File.prototype.copy = function(destination, callback) {
   }
 
   var query = {};
-  if (is.number(this.generation)) {
+  if (is.defined(this.generation)) {
     query.sourceGeneration = this.generation;
   }
 
@@ -1464,7 +1465,7 @@ File.prototype.startSimpleUpload_ = function(dup, metadata) {
     })
   };
 
-  if (is.number(this.generation)) {
+  if (is.defined(this.generation)) {
     reqOpts.qs.ifGenerationMatch = this.generation;
   }