Merge pull request #920 from stephenplusplus/spp--http-parsing-regres…

…sion don't parse an undefined message or body
googleapis · Oct 28, 2015 · f2508b3 · f2508b3
2 parents f23d3d5 + 96ab971
commit f2508b3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/common/util.js b/lib/common/util.js
@@ -142,8 +142,8 @@ function handleResp(err, resp, body, callback) {
   var parsedResp = extend(
     true,
     { err: err || null },
-    util.parseHttpRespMessage(resp),
-    util.parseHttpRespBody(body)
+    resp && util.parseHttpRespMessage(resp),
+    body && util.parseHttpRespBody(body)
   );
 
   callback(parsedResp.err, parsedResp.body, parsedResp.resp);

diff --git a/test/common/util.js b/test/common/util.js
@@ -230,6 +230,22 @@ describe('common/util', function() {
         done();
       });
     });
+
+    it('should not parse undefined response', function(done) {
+      utilOverrides.parseHttpRespMessage = function() {
+        done(); // Will throw.
+      };
+
+      util.handleResp(null, null, null, done);
+    });
+
+    it('should not parse undefined body', function(done) {
+      utilOverrides.parseHttpRespBody = function() {
+        done(); // Will throw.
+      };
+
+      util.handleResp(null, null, null, done);
+    });
   });
 
   describe('parseHttpRespMessage', function() {