Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where is the code for Dataset.get() ...? #537

Closed
jgeewax opened this issue May 7, 2015 · 6 comments
Closed

Where is the code for Dataset.get() ...? #537

jgeewax opened this issue May 7, 2015 · 6 comments
Assignees
@stephenplusplus
Labels
api: datastore Issues related to the Datastore API. type: question Request for information or clarification. Not an issue.
Milestone
Datastore Stable

Comments

@jgeewax
Copy link
Contributor

jgeewax commented May 7, 2015

If I go to http://googlecloudplatform.github.io/gcloud-node/#/docs/v0.14.0/datastore/dataset?method=get

And click the "view code" link (https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.14.0/lib/datastore/dataset.js#L102) I'm taken to an empty line...

Looking around in the file didn't send me to any code...

Is this method magically injected somehow?
@jgeewax jgeewax added type: question Request for information or clarification. Not an issue. api: datastore Issues related to the Datastore API. labels May 7, 2015
@jgeewax jgeewax added this to the Datastore Stable milestone May 7, 2015
@stephenplusplus
Copy link
Contributor

Oh man, the complicated web that is JSDocs + the Docs -> MD tool we use + how we rig things up on the FE. A Dataset has a @­mixin of the Transaction class, which is where get comes from. http://googlecloudplatform.github.io/gcloud-node/#/docs/v0.14.0/datastore/transaction?method=get

Off the top of my head, I can't think of an easy way to solve for this, but will think on it.

@jgeewax
Copy link
Contributor Author

jgeewax commented May 7, 2015 via email

@stephenplusplus
Copy link
Contributor

Oops, the web gets webbier. Transaction itself has a @­mixin on the DatastoreRequest class, which is finally where get lives: https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.14.0/lib/datastore/request.js#L102

@ryanseys
Copy link
Contributor

ryanseys commented May 7, 2015

So it got the line number right, but the file wrong. I don't know if that helps make things any easier?

@stephenplusplus
Copy link
Contributor

That does, indeed. Let's see what we can do about this...

@stephenplusplus stephenplusplus self-assigned this May 8, 2015
@stephenplusplus
Copy link
Contributor

This was resolved by #584 - I tagged the wrong issue in the PR.

chingor13 pushed a commit that referenced this issue Aug 22, 2022
@gcf-owl-bot
feat: Release of relationships in v1, Add content type Relationship t…
6ccf5c2 
…o support relationship export (#537)

Committer: lvv@

PiperOrigin-RevId: 391065985

Source-Link: googleapis/googleapis@b9e69f8

Source-Link: googleapis/googleapis-gen@6d0f250
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@release-please
chore: release 3.16.0 (#539)
d3b7229 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.16.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.5...v3.16.0) (2021-08-16)


### Features

* Release of relationships in v1, Add content type Relationship to support relationship export ([#537](https://www.github.com/googleapis/nodejs-asset/issues/537)) ([873aae6](https://www.github.com/googleapis/nodejs-asset/commit/873aae6f9b846a16b5695b692e8ad668d684dc6c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@gcf-owl-bot
feat: Release of relationships in v1, Add content type Relationship t…
03d3ec0 
…o support relationship export (#537)

Committer: lvv@

PiperOrigin-RevId: 391065985

Source-Link: googleapis/googleapis@b9e69f8

Source-Link: googleapis/googleapis-gen@6d0f250
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@release-please
chore: release 3.16.0 (#539)
00483ce 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.16.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.5...v3.16.0) (2021-08-16)


### Features

* Release of relationships in v1, Add content type Relationship to support relationship export ([#537](https://www.github.com/googleapis/nodejs-asset/issues/537)) ([873aae6](https://www.github.com/googleapis/nodejs-asset/commit/873aae6f9b846a16b5695b692e8ad668d684dc6c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@gcf-owl-bot
feat: Release of relationships in v1, Add content type Relationship t…
7aab39e 
…o support relationship export (#537)

Committer: lvv@

PiperOrigin-RevId: 391065985

Source-Link: googleapis/googleapis@b9e69f8

Source-Link: googleapis/googleapis-gen@6d0f250
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@release-please
chore: release 3.16.0 (#539)
edd9559 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.16.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.5...v3.16.0) (2021-08-16)


### Features

* Release of relationships in v1, Add content type Relationship to support relationship export ([#537](https://www.github.com/googleapis/nodejs-asset/issues/537)) ([873aae6](https://www.github.com/googleapis/nodejs-asset/commit/873aae6f9b846a16b5695b692e8ad668d684dc6c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 11, 2022
@renovate-bot
fix(deps): update dependency mathjs to v9 (#537)
f7eb298
sofisl pushed a commit that referenced this issue Oct 13, 2022
@renovate-bot @sofisl
fix(deps): update dependency mathjs to v9 (#537)
2bdbe38
@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 10, 2022
@fhinkel
chore(nodejs): remove api-extractor dependencies (#537)
6a3a873
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@renovate-bot
chore(deps): update dependency sinon to v14 (#537)
f88a036
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: new owl bot post processor docker image (#537)
72da3d0 
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:b94b09fb24bf804090b8cc60ee726ca161d5e5915151e417f8ef5d8bcfe73cbc
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
feat: Release of relationships in v1, Add content type Relationship t…
ec747d8 
…o support relationship export (#537)

Committer: lvv@

PiperOrigin-RevId: 391065985

Source-Link: googleapis/googleapis@b9e69f8

Source-Link: googleapis/googleapis-gen@6d0f250
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 3.16.0 (#539)
d9bfb7b 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.16.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.5...v3.16.0) (2021-08-16)


### Features

* Release of relationships in v1, Add content type Relationship to support relationship export ([#537](https://www.github.com/googleapis/nodejs-asset/issues/537)) ([873aae6](https://www.github.com/googleapis/nodejs-asset/commit/873aae6f9b846a16b5695b692e8ad668d684dc6c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
docs(samples): include metadata file, add exclusions for samples to h…
baa4eab 
…andwritten libraries (#537)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 429395631

Source-Link: googleapis/googleapis@84594b3

Source-Link: googleapis/googleapis-gen@ed74f97
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
sofisl pushed a commit that referenced this issue Nov 17, 2022
@alexander-fenster
feat!: new generated version of compute API (#537)
ddc6369
sofisl pushed a commit that referenced this issue Nov 17, 2022
@release-please
chore: release 3.0.0 (#599)
9141f1c 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.0.0](https://www.github.com/googleapis/nodejs-compute/compare/v2.6.0...v3.0.0) (2021-08-17)


### ⚠ BREAKING CHANGES

* new generated version of compute API (#537)

### Features

* new generated version of compute API ([#537](https://www.github.com/googleapis/nodejs-compute/issues/537)) ([4023676](https://www.github.com/googleapis/nodejs-compute/commit/4023676e121e3b3c71b681dbd77136ab74184e68))


### Bug Fixes

* **build:** migrate to using main branch ([#609](https://www.github.com/googleapis/nodejs-compute/issues/609)) ([3013bb5](https://www.github.com/googleapis/nodejs-compute/commit/3013bb53258d738e136327fd027b6ea4fae835db))
* **deps:** google-gax v2.24.1 ([#612](https://www.github.com/googleapis/nodejs-compute/issues/612)) ([8569747](https://www.github.com/googleapis/nodejs-compute/commit/856974738ab7051cdbf05575bc5871c0b6b4ea28))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Nov 17, 2022
Merged
4 tasks
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@release-please
chore: release 3.0.3 (#537)
787896f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@evil-shrike evil-shrike mentioned this issue Jan 27, 2023
Open
@sofisl sofisl mentioned this issue Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 13, 2023
@release-please
chore: release 2.4.4 (#537)
f015ae9 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.4.4](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.3...v2.4.4) (2021-08-11)


### Bug Fixes

* **build:** migrate to using main branch ([#536](https://www.github.com/googleapis/nodejs-automl/issues/536)) ([1185736](https://www.github.com/googleapis/nodejs-automl/commit/1185736efefca56e2f86ac52ad340d231d92c25f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: datastore Issues related to the Datastore API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
Datastore Stable
Development

No branches or pull requests
3 participants
@jgeewax @ryanseys @stephenplusplus