Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the acl add doesn't work #569

Closed
khmereshop opened this issue May 9, 2015 · 3 comments
Closed

the acl add doesn't work #569

khmereshop opened this issue May 9, 2015 · 3 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@khmereshop
Copy link

the acl does not work. When I display the myFile, It does not object reference to myFile.acl.add

var myFile = bucket.file(filename);

console.log(myFile);

myFile.acl.update({
  scope: 'allUsers',
  permission: storage.acl.READER_ROLE
}, function(err, aclObject) {

  console.log('**** error ****');

  console.log(err);
  console.log(aclObject);
});
@jgeewax jgeewax added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels May 9, 2015
@ryanseys
Copy link
Contributor

Hey @khmereshop sorry for the delay. I'm sorry but I don't really understand the issue here. Can you take a look at the system tests here where we are testing our acl.add method. That might help you make sense of what acl.add is meant to do. Your sample code given seems to also be using acl.update and not acl.add so if you could clarify why and what your code is supposed to show, that'd be great!

@stephenplusplus
Copy link
Contributor

@khmereshop are you still having an issue?

@stephenplusplus
Copy link
Contributor

Please re-open if you are still experiencing this :)

chingor13 pushed a commit that referenced this issue Aug 22, 2022
… DAILY frequency (#569)

Committer: @coodie
PiperOrigin-RevId: 403998997
Source-Link: googleapis/googleapis@0dfce5e
Source-Link: googleapis/googleapis-gen@ccde479
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2NkZTQ3OTE4YjRmMTMyZTdkOTk1MzYzZDJjNTVmODAxZDA2YjcxNCJ9
chingor13 pushed a commit that referenced this issue Aug 22, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this issue Aug 22, 2022
… DAILY frequency (#569)

Committer: @coodie
PiperOrigin-RevId: 403998997
Source-Link: googleapis/googleapis@0dfce5e
Source-Link: googleapis/googleapis-gen@ccde479
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2NkZTQ3OTE4YjRmMTMyZTdkOTk1MzYzZDJjNTVmODAxZDA2YjcxNCJ9
chingor13 pushed a commit that referenced this issue Aug 22, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this issue Aug 22, 2022
… DAILY frequency (#569)

Committer: @coodie
PiperOrigin-RevId: 403998997
Source-Link: googleapis/googleapis@0dfce5e
Source-Link: googleapis/googleapis-gen@ccde479
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2NkZTQ3OTE4YjRmMTMyZTdkOTk1MzYzZDJjNTVmODAxZDA2YjcxNCJ9
chingor13 pushed a commit that referenced this issue Aug 22, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-cloud-container@v4.1.3...v4.2.0) (2022-09-22)


### Features

* Added High Throughput Logging API for Google Kubernetes Engine ([#571](googleapis/nodejs-cloud-container#571)) ([588b19a](googleapis/nodejs-cloud-container@588b19a))


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#568](googleapis/nodejs-cloud-container#568)) ([575531f](googleapis/nodejs-cloud-container@575531f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.0](googleapis/nodejs-iot@v2.5.1...v3.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#566)

### Features

* AuditConfig for IAM v1 ([#552](googleapis/nodejs-iot#552)) ([1b1a3d2](googleapis/nodejs-iot@1b1a3d2))


### Bug Fixes

* **deps:** update dependency @google-cloud/pubsub to v3 ([#569](googleapis/nodejs-iot#569)) ([77a2005](googleapis/nodejs-iot@77a2005))
* **deps:** update dependency @google-cloud/storage to v6 ([#568](googleapis/nodejs-iot#568)) ([b15efb4](googleapis/nodejs-iot@b15efb4))


### Build System

* update library to use Node 12 ([#566](googleapis/nodejs-iot#566)) ([1efe654](googleapis/nodejs-iot@1efe654))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
* sample-test should fail

* fix resource name

* lint

* test

* update copyright

* pick up v2/ proto change

* fix sample-test for proto change

* new resource name

* test

* test

* test

* test

* proper resource path

* all green now

* fix & gts lint

* remove createDocument test

* lint

Co-authored-by: Alexander Fenster <fenster@google.com>
sofisl pushed a commit that referenced this issue Nov 11, 2022
… DAILY frequency (#569)

Committer: @coodie
PiperOrigin-RevId: 403998997
Source-Link: googleapis/googleapis@0dfce5e
Source-Link: googleapis/googleapis-gen@ccde479
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2NkZTQ3OTE4YjRmMTMyZTdkOTk1MzYzZDJjNTVmODAxZDA2YjcxNCJ9
sofisl pushed a commit that referenced this issue Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl pushed a commit that referenced this issue Jan 10, 2023
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/15862244-2697-4da9-a237-b292c9805d53/targets

- [ ] To automatically regenerate this PR, check this box.
sofisl pushed a commit that referenced this issue Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants