[Bug] incorrect conversion of batch insertion in Datastore #875

dg3feiko · 2015-09-20T12:23:33Z

Env

Node: 2.3.3
gcloud: 0.21.0

Problem

for single insert

var res;

        data = [
            {
                name: "foo",
                value: {
                    bar: [
                        {hello: 1},
                        {hello: 2}
                    ]
                }
            }
        ];

        //save to datastore
        res = yield dataset.saveAsync([
                {
                    key: dataset.key({
                        path: ['MyKind', "123"]
                    }),
                    data: data
                },

            ]
        );

        res = yield dataset.getAsync(
            dataset.key(['MyKind', "123"])
        );

        console.log(JSON.stringify(res, null, 2));

output

{
  "key": {
    "path": [
      "MyKind",
      123
    ]
  },
  "data": {
    "foo": {
      "bar": [
        {
          "hello": 1
        },
        {
          "hello": 2
        }
      ]
    }
  }
}

but for multiple inserts

var res;

        data = [
            {
                name: "foo",
                value: {
                    bar: [
                        {hello: 1},
                        {hello: 2}
                    ]
                }
            }
        ];

        //save to datastore
        res = yield dataset.saveAsync([
                {
                    key: dataset.key({
                        path: ['MyKind', "123"]
                    }),
                    data: data
                },
                {
                    key: dataset.key({
                        path: ['MyKind', "234"]
                    }),
                    data: data
                }
            ]
        );

        res = yield dataset.getAsync(
            dataset.key(['MyKind', "123"])
        );

        console.log(JSON.stringify(res, null, 2));

the output is

{
  "key": {
    "path": [
      "MyKind",
      123
    ]
  },
  "data": {
    "foo": {
      "entity_value": {
        "property": [
          {
            "name": "bar",
            "value": {
              "list_value": [
                {
                  "entity_value": {
                    "property": [
                      {
                        "name": "hello",
                        "value": {
                          "integer_value": 1
                        }
                      }
                    ]
                  },
                  "indexed": false
                },
                {
                  "entity_value": {
                    "property": [
                      {
                        "name": "hello",
                        "value": {
                          "integer_value": 2
                        }
                      }
                    ]
                  },
                  "indexed": false
                }
              ]
            }
          }
        ]
      },
      "indexed": false
    }
  }
}

dg3feiko · 2015-09-20T12:46:04Z

for single insert
the raw request body is

{
    "mutation": {
        "insert": [],
        "update": [],
        "upsert": [
            {
                "property": [
                    {
                        "name": "foo",
                        "value": {
                            "entity_value": {
                                "property": [
                                    {
                                        "name": "bar",
                                        "value": {
                                            "list_value": [
                                                {
                                                    "entity_value": {
                                                        "property": [
                                                            {
                                                                "name": "hello",
                                                                "value": {
                                                                    "integer_value": 1
                                                                }
                                                            }
                                                        ]
                                                    },
                                                    "indexed": false
                                                },
                                                {
                                                    "entity_value": {
                                                        "property": [
                                                            {
                                                                "name": "hello",
                                                                "value": {
                                                                    "integer_value": 2
                                                                }
                                                            }
                                                        ]
                                                    },
                                                    "indexed": false
                                                }
                                            ]
                                        }
                                    }
                                ]
                            },
                            "indexed": false
                        }
                    }
                ],
                "key": {
                    "path_element": [
                        {
                            "kind": "MyKind",
                            "id": "123"
                        }
                    ]
                }
            }
        ],
        "insert_auto_id": []
    }
}

for multiple one
the body is

{
    "mutation": {
        "insert": [],
        "update": [],
        "upsert": [
            {
                "property": [
                    {
                        "name": "foo",
                        "value": {
                            "entity_value": {
                                "property": [
                                    {
                                        "name": "entity_value",
                                        "value": {
                                            "entity_value": {
                                                "property": [
                                                    {
                                                        "name": "property",
                                                        "value": {
                                                            "list_value": [
                                                                {
                                                                    "entity_value": {
                                                                        "property": [
                                                                            {
                                                                                "name": "name",
                                                                                "value": {
                                                                                    "string_value": "bar"
                                                                                }
                                                                            },
                                                                            {
                                                                                "name": "value",
                                                                                "value": {
                                                                                    "entity_value": {
                                                                                        "property": [
                                                                                            {
                                                                                                "name": "list_value",
                                                                                                "value": {
                                                                                                    "list_value": [
                                                                                                        {
                                                                                                            "entity_value": {
                                                                                                                "property": [
                                                                                                                    {
                                                                                                                        "name": "entity_value",
                                                                                                                        "value": {
                                                                                                                            "entity_value": {
                                                                                                                                "property": [
                                                                                                                                    {
                                                                                                                                        "name": "property",
                                                                                                                                        "value": {
                                                                                                                                            "list_value": [
                                                                                                                                                {
                                                                                                                                                    "entity_value": {
                                                                                                                                                        "property": [
                                                                                                                                                            {
                                                                                                                                                                "name": "name",
                                                                                                                                                                "value": {
                                                                                                                                                                    "string_value": "hello"
                                                                                                                                                                }
                                                                                                                                                            },
                                                                                                                                                            {
                                                                                                                                                                "name": "value",
                                                                                                                                                                "value": {
                                                                                                                                                                    "entity_value": {
                                                                                                                                                                        "property": [
                                                                                                                                                                            {
                                                                                                                                                                                "name": "integer_value",
                                                                                                                                                                                "value": {
                                                                                                                                                                                    "integer_value": 1
                                                                                                                                                                                }
                                                                                                                                                                            }
                                                                                                                                                                        ]
                                                                                                                                                                    },
                                                                                                                                                                    "indexed": false
                                                                                                                                                                }
                                                                                                                                                            }
                                                                                                                                                        ]
                                                                                                                                                    },
                                                                                                                                                    "indexed": false
                                                                                                                                                }
                                                                                                                                            ]
                                                                                                                                        }
                                                                                                                                    }
                                                                                                                                ]
                                                                                                                            },
                                                                                                                            "indexed": false
                                                                                                                        }
                                                                                                                    },
                                                                                                                    {
                                                                                                                        "name": "indexed",
                                                                                                                        "value": {
                                                                                                                            "boolean_value": false
                                                                                                                        }
                                                                                                                    }
                                                                                                                ]
                                                                                                            },
                                                                                                            "indexed": false
                                                                                                        },
                                                                                                        {
                                                                                                            "entity_value": {
                                                                                                                "property": [
                                                                                                                    {
                                                                                                                        "name": "entity_value",
                                                                                                                        "value": {
                                                                                                                            "entity_value": {
                                                                                                                                "property": [
                                                                                                                                    {
                                                                                                                                        "name": "property",
                                                                                                                                        "value": {
                                                                                                                                            "list_value": [
                                                                                                                                                {
                                                                                                                                                    "entity_value": {
                                                                                                                                                        "property": [
                                                                                                                                                            {
                                                                                                                                                                "name": "name",
                                                                                                                                                                "value": {
                                                                                                                                                                    "string_value": "hello"
                                                                                                                                                                }
                                                                                                                                                            },
                                                                                                                                                            {
                                                                                                                                                                "name": "value",
                                                                                                                                                                "value": {
                                                                                                                                                                    "entity_value": {
                                                                                                                                                                        "property": [
                                                                                                                                                                            {
                                                                                                                                                                                "name": "integer_value",
                                                                                                                                                                                "value": {
                                                                                                                                                                                    "integer_value": 2
                                                                                                                                                                                }
                                                                                                                                                                            }
                                                                                                                                                                        ]
                                                                                                                                                                    },
                                                                                                                                                                    "indexed": false
                                                                                                                                                                }
                                                                                                                                                            }
                                                                                                                                                        ]
                                                                                                                                                    },
                                                                                                                                                    "indexed": false
                                                                                                                                                }
                                                                                                                                            ]
                                                                                                                                        }
                                                                                                                                    }
                                                                                                                                ]
                                                                                                                            },
                                                                                                                            "indexed": false
                                                                                                                        }
                                                                                                                    },
                                                                                                                    {
                                                                                                                        "name": "indexed",
                                                                                                                        "value": {
                                                                                                                            "boolean_value": false
                                                                                                                        }
                                                                                                                    }
                                                                                                                ]
                                                                                                            },
                                                                                                            "indexed": false
                                                                                                        }
                                                                                                    ]
                                                                                                }
                                                                                            }
                                                                                        ]
                                                                                    },
                                                                                    "indexed": false
                                                                                }
                                                                            }
                                                                        ]
                                                                    },
                                                                    "indexed": false
                                                                }
                                                            ]
                                                        }
                                                    }
                                                ]
                                            },
                                            "indexed": false
                                        }
                                    },
                                    {
                                        "name": "indexed",
                                        "value": {
                                            "boolean_value": false
                                        }
                                    }
                                ]
                            },
                            "indexed": false
                        }
                    }
                ],
                "key": {
                    "path_element": [
                        {
                            "kind": "MyKind",
                            "id": "123"
                        }
                    ]
                }
            },
            {
                "property": [
                    {
                        "name": "foo",
                        "value": {
                            "entity_value": {
                                "property": [
                                    {
                                        "name": "entity_value",
                                        "value": {
                                            "entity_value": {
                                                "property": [
                                                    {
                                                        "name": "property",
                                                        "value": {
                                                            "list_value": [
                                                                {
                                                                    "entity_value": {
                                                                        "property": [
                                                                            {
                                                                                "name": "name",
                                                                                "value": {
                                                                                    "string_value": "bar"
                                                                                }
                                                                            },
                                                                            {
                                                                                "name": "value",
                                                                                "value": {
                                                                                    "entity_value": {
                                                                                        "property": [
                                                                                            {
                                                                                                "name": "list_value",
                                                                                                "value": {
                                                                                                    "list_value": [
                                                                                                        {
                                                                                                            "entity_value": {
                                                                                                                "property": [
                                                                                                                    {
                                                                                                                        "name": "entity_value",
                                                                                                                        "value": {
                                                                                                                            "entity_value": {
                                                                                                                                "property": [
                                                                                                                                    {
                                                                                                                                        "name": "property",
                                                                                                                                        "value": {
                                                                                                                                            "list_value": [
                                                                                                                                                {
                                                                                                                                                    "entity_value": {
                                                                                                                                                        "property": [
                                                                                                                                                            {
                                                                                                                                                                "name": "name",
                                                                                                                                                                "value": {
                                                                                                                                                                    "string_value": "hello"
                                                                                                                                                                }
                                                                                                                                                            },
                                                                                                                                                            {
                                                                                                                                                                "name": "value",
                                                                                                                                                                "value": {
                                                                                                                                                                    "entity_value": {
                                                                                                                                                                        "property": [
                                                                                                                                                                            {
                                                                                                                                                                                "name": "integer_value",
                                                                                                                                                                                "value": {
                                                                                                                                                                                    "integer_value": 1
                                                                                                                                                                                }
                                                                                                                                                                            }
                                                                                                                                                                        ]
                                                                                                                                                                    },
                                                                                                                                                                    "indexed": false
                                                                                                                                                                }
                                                                                                                                                            }
                                                                                                                                                        ]
                                                                                                                                                    },
                                                                                                                                                    "indexed": false
                                                                                                                                                }
                                                                                                                                            ]
                                                                                                                                        }
                                                                                                                                    }
                                                                                                                                ]
                                                                                                                            },
                                                                                                                            "indexed": false
                                                                                                                        }
                                                                                                                    },
                                                                                                                    {
                                                                                                                        "name": "indexed",
                                                                                                                        "value": {
                                                                                                                            "boolean_value": false
                                                                                                                        }
                                                                                                                    }
                                                                                                                ]
                                                                                                            },
                                                                                                            "indexed": false
                                                                                                        },
                                                                                                        {
                                                                                                            "entity_value": {
                                                                                                                "property": [
                                                                                                                    {
                                                                                                                        "name": "entity_value",
                                                                                                                        "value": {
                                                                                                                            "entity_value": {
                                                                                                                                "property": [
                                                                                                                                    {
                                                                                                                                        "name": "property",
                                                                                                                                        "value": {
                                                                                                                                            "list_value": [
                                                                                                                                                {
                                                                                                                                                    "entity_value": {
                                                                                                                                                        "property": [
                                                                                                                                                            {
                                                                                                                                                                "name": "name",
                                                                                                                                                                "value": {
                                                                                                                                                                    "string_value": "hello"
                                                                                                                                                                }
                                                                                                                                                            },
                                                                                                                                                            {
                                                                                                                                                                "name": "value",
                                                                                                                                                                "value": {
                                                                                                                                                                    "entity_value": {
                                                                                                                                                                        "property": [
                                                                                                                                                                            {
                                                                                                                                                                                "name": "integer_value",
                                                                                                                                                                                "value": {
                                                                                                                                                                                    "integer_value": 2
                                                                                                                                                                                }
                                                                                                                                                                            }
                                                                                                                                                                        ]
                                                                                                                                                                    },
                                                                                                                                                                    "indexed": false
                                                                                                                                                                }
                                                                                                                                                            }
                                                                                                                                                        ]
                                                                                                                                                    },
                                                                                                                                                    "indexed": false
                                                                                                                                                }
                                                                                                                                            ]
                                                                                                                                        }
                                                                                                                                    }
                                                                                                                                ]
                                                                                                                            },
                                                                                                                            "indexed": false
                                                                                                                        }
                                                                                                                    },
                                                                                                                    {
                                                                                                                        "name": "indexed",
                                                                                                                        "value": {
                                                                                                                            "boolean_value": false
                                                                                                                        }
                                                                                                                    }
                                                                                                                ]
                                                                                                            },
                                                                                                            "indexed": false
                                                                                                        }
                                                                                                    ]
                                                                                                }
                                                                                            }
                                                                                        ]
                                                                                    },
                                                                                    "indexed": false
                                                                                }
                                                                            }
                                                                        ]
                                                                    },
                                                                    "indexed": false
                                                                }
                                                            ]
                                                        }
                                                    }
                                                ]
                                            },
                                            "indexed": false
                                        }
                                    },
                                    {
                                        "name": "indexed",
                                        "value": {
                                            "boolean_value": false
                                        }
                                    }
                                ]
                            },
                            "indexed": false
                        }
                    }
                ],
                "key": {
                    "path_element": [
                        {
                            "kind": "MyKind",
                            "id": "234"
                        }
                    ]
                }
            }
        ],
        "insert_auto_id": []
    }
}

stephenplusplus · 2015-09-21T20:14:46Z

Fix incoming!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/compatibility-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.11.9/confidence-slim/16.18.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-translate).

stephenplusplus added api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 20, 2015

stephenplusplus mentioned this issue Sep 21, 2015

datastore: prevent manipulating user input during save #881

Merged

callmehiphop closed this as completed in #881 Sep 21, 2015

JustinBeckwith assigned yoshi-automation Feb 1, 2021

sofisl mentioned this issue Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] incorrect conversion of batch insertion in Datastore #875

[Bug] incorrect conversion of batch insertion in Datastore #875

dg3feiko commented Sep 20, 2015

dg3feiko commented Sep 20, 2015

stephenplusplus commented Sep 21, 2015

[Bug] incorrect conversion of batch insertion in Datastore #875

[Bug] incorrect conversion of batch insertion in Datastore #875

Comments

dg3feiko commented Sep 20, 2015

Env

Problem

dg3feiko commented Sep 20, 2015

stephenplusplus commented Sep 21, 2015