Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: address early return rule per latest jscs release #1010

Merged
merged 1 commit into from
Dec 9, 2015
Merged

core: address early return rule per latest jscs release #1010

merged 1 commit into from
Dec 9, 2015

Conversation

callmehiphop
Copy link
Contributor

jscs released a new version that implemented a new rule which broke our build

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2015
@callmehiphop callmehiphop added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. core labels Dec 9, 2015
@stephenplusplus
Copy link
Contributor

You're not allowed to release again.

stephenplusplus added a commit that referenced this pull request Dec 9, 2015
core: address early return rule per latest jscs release
@stephenplusplus stephenplusplus merged commit f63eb9b into googleapis:master Dec 9, 2015
@callmehiphop
Copy link
Contributor Author

._.

sofisl pushed a commit that referenced this pull request Nov 11, 2022
fix: update proto definitions

Source-Link: googleapis/synthtool@0a68e56
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. core type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants