Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: allow aborting an active HTTP request + auto-abort when subsc… #1105

Merged
merged 1 commit into from
Feb 4, 2016
Merged

pubsub: allow aborting an active HTTP request + auto-abort when subsc… #1105

merged 1 commit into from
Feb 4, 2016

Conversation

stephenplusplus
Copy link
Contributor

…ription closed

RE: #1104

This modifies our core request functionality to expose an abort function which cancels an active HTTP request (via request).

@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. core labels Feb 3, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2016
@stephenplusplus stephenplusplus mentioned this pull request Feb 3, 2016
Closed
callmehiphop
callmehiphop reviewed Feb 3, 2016
View reviewed changes
lib/common/util.js
return {
abort: function() {
if (activeRequest_) {
activeRequest_.abort();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop
callmehiphop reviewed Feb 4, 2016
View reviewed changes
test/common/util.js
makeAuthenticatedRequest(reqOpts, assert.ifError).abort();
});

it.only('should only abort() once', function(done) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop added a commit that referenced this pull request Feb 4, 2016
@callmehiphop
Merge pull request #1105 from stephenplusplus/spp--1104
2bc840c 
pubsub: allow aborting an active HTTP request + auto-abort when subsc…
@callmehiphop callmehiphop merged commit 2bc840c into googleapis:master Feb 4, 2016
ctavan added a commit to ctavan/google-cloud-node that referenced this pull request Feb 3, 2017
@ctavan
pubsub: Fix broken abortion of outstanding requests
2d6a54d 
This restores the fix from googleapis#1105
which was broken after googleapis#1070
@ctavan ctavan mentioned this pull request Feb 3, 2017
Closed
ctavan added a commit to ctavan/google-cloud-node that referenced this pull request Feb 3, 2017
@ctavan
pubsub: Fix broken abortion of outstanding requests
72129dd 
This restores the fix from googleapis#1105
which was broken after googleapis#1070
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. core type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenplusplus @callmehiphop @googlebot